Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it make sense to support --ff-only for release? #30

Closed
raehalme opened this issue Feb 2, 2017 · 3 comments
Closed

Would it make sense to support --ff-only for release? #30

raehalme opened this issue Feb 2, 2017 · 3 comments

Comments

@raehalme
Copy link
Contributor

raehalme commented Feb 2, 2017

I'm including this plugin in our development process and was wondering if it would make sense to support --ff-only when merging the release branch to master? I would like to see the master branch updated "as is" without any changes from the release branch.

@aleksandr-m
Copy link
Owner

What are you trying to achieve with that? What is the use case?

Are you sure that --ff-only is what you want?

--ff-only

Refuse to merge and exit with a non-zero status unless the current HEAD is already up-to-date or the merge can be resolved as a fast-forward.

@raehalme
Copy link
Contributor Author

raehalme commented Feb 2, 2017

I would like the master branch to represent the last commit of the latest release. The release branch is used to prepare the release, build the artifacts, and the master should just point to the final commit of the release branch.

If there is a merge commit in the master branch, then master does not necessarily represent the same content that was in the release branch where the release was prepared and probably tested too.

The option --ff-only can be used to enforce this requirement.

@raehalme
Copy link
Contributor Author

raehalme commented Feb 3, 2017

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants