Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*-start goals don't update version of child modules #48

Closed
arikkfir opened this issue Jun 2, 2017 · 4 comments
Closed

*-start goals don't update version of child modules #48

arikkfir opened this issue Jun 2, 2017 · 4 comments

Comments

@arikkfir
Copy link

arikkfir commented Jun 2, 2017

When running a "-start" goal on a multi-module project (at the root), only the root's version is updated to the new release's version.

@arikkfir
Copy link
Author

arikkfir commented Jun 2, 2017

See pull request #49

@aleksandr-m
Copy link
Owner

Do you have different group id for the module projects? Can you show relevant parts of your projects pom xmls? Or create a MCVE?

@aleksandr-m
Copy link
Owner

@arikkfir ^ ping!

@ghost
Copy link

ghost commented Dec 16, 2017

One thing to note - versions-maven-plugin added the <processAllModules> property in version 2.5 of that plugin. I've used that in a mixed multi module project where a parent module is used to inherit an external parent POM and most of the modules don't inherit from the root POM. Looks like gitflow uses a hardcoded 2.1 version for the versions:set goal here

private static final String VERSIONS_MAVEN_PLUGIN_SET_GOAL = "org.codehaus.mojo:versions-maven-plugin:2.1:set";

Exposing that behavior via the gitflow might be a simpler solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants