Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd/Unexpected String Character Case on Non-Prices #1

Open
srsgores opened this issue Mar 4, 2018 · 3 comments
Open

Odd/Unexpected String Character Case on Non-Prices #1

srsgores opened this issue Mar 4, 2018 · 3 comments

Comments

@srsgores
Copy link

srsgores commented Mar 4, 2018

With the extension installed, it appears that non-price strings get modified:

Note the difference in the case of this site's main nav:

image

vs.

image

The issue could be related to this line.

@AleksueiR
Copy link
Collaborator

Hi, @srsgores, thank you for reporting.

The app looks for prices by breaking all the strings on the page and wrapping them in new nodes based on a patter. Anything that is not a price, gets unwrapped after the initial parsing. When the string pieces are unwrapped, they end up as separate text nodes:

And the styles on this page have a rule to capitalize link text which applies to all the text nodes inside that link:

    text-transform: capitalize;

That's why you get this strange capitalization.

I have no idea when/if I get time to fix this though :/

@BoltonBailey
Copy link

I am having this issue as well. I take it there are no plans to fix this.

@AleksueiR
Copy link
Collaborator

I'm afraid no, there are no plans right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants