Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove publish_file methods from Archives #3880

Open
catileptic opened this issue Jun 17, 2024 · 1 comment
Open

Remove publish_file methods from Archives #3880

catileptic opened this issue Jun 17, 2024 · 1 comment
Labels
Minor servicelayer side-quest

Comments

@catileptic
Copy link
Contributor

As per #3751, we should remove the publish_file methods
@tillprochaska
Copy link
Contributor

As far as I can see, the only use case for this method was the option to publish Aleph network diagrams. Once that’s fully removed from Aleph, there’s no reason to keep this code around in any of the archive implementations.

This includes:

  • The Archive ABC and the S3 and GS archive implementations
  • The PUBLICATION_BUCKET configuration option

@stchris stchris transferred this issue from alephdata/servicelayer Oct 18, 2024
@stchris stchris added triage These issues need to be reviewed by the Aleph team servicelayer labels Oct 18, 2024
@catileptic catileptic added Minor side-quest and removed triage These issues need to be reviewed by the Aleph team labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Minor servicelayer side-quest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stchris @tillprochaska @catileptic