Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Address from/to not clear on Overview #301

Closed
LeeAlephium opened this issue Jul 18, 2022 · 9 comments
Closed

Address from/to not clear on Overview #301

LeeAlephium opened this issue Jul 18, 2022 · 9 comments
Assignees
Labels
improvement Improves an already existing feature

Comments

@LeeAlephium
Copy link
Contributor

On an address's transaction overview it's clear where funds are traveling because it shows "To/From"

1658140876

But it's very unclear on the Overview

1658140869

@LeeAlephium LeeAlephium added the improvement Improves an already existing feature label Jul 18, 2022
@mvaivre
Copy link
Member

mvaivre commented Jul 19, 2022

So, after taking a second look at my mockups, with a colder head (literally) : the idea was to keep the overview TX history uncluttered. But I agree that the current state can be confusing.

I've updated my mockups with a more complete table (note the updated - more lightweight - icons and labels, inspired by the work on the mobile version).

image

I'm not yet sure if this is t0o dense or if it's fine. If too dense, we may remove the address label, and keep the same info as in the address's transaction overview.

@mvaivre
Copy link
Member

mvaivre commented Jul 19, 2022

Less cluttered :

image

@LeeAlephium LeeAlephium self-assigned this Aug 1, 2022
@LeeAlephium
Copy link
Contributor Author

Should the new address badges be reflected in the entire application? Currently that's what I've done...

@mvaivre
Copy link
Member

mvaivre commented Aug 2, 2022

Should the new address badges be reflected in the entire application? Currently that's what I've done...

Yes. Thanks :)

@LeeAlephium
Copy link
Contributor Author

LeeAlephium commented Aug 2, 2022

I'm going to extend the width a bit on the cards, the names are not useful anymore otherwise

1659443375

1659443550

@mvaivre
Copy link
Member

mvaivre commented Aug 2, 2022

Yeah. This section will eventually need to be redesigned. I'll take some inspiration from my work on the mobile wallet.
Two things:

  • Could you center the label horizontally and reduce the padding between the dot/star and the label ? :) (in this task)
  • A note for later: this scrollbar is ugly. I think we could switch to a css scrollbar mimicking the MacOS one (which is IMO way more discreet and elegant). Associated task: Use custom CSS scrollbars for consistent look across OSes #313.

@LeeAlephium
Copy link
Contributor Author

The current api-explorer.ts doesn't seem to support tokens yet in the Transaction interface. For now I'll just use "ALPH" by default

@LeeAlephium
Copy link
Contributor Author

Do we want to reflect the new transaction history design on the address details page as well? This is currently what I'm doing since UX consistency seems like a good goal. I would hide the address label but that's about all I can imagine that would need to be different...

@mvaivre
Copy link
Member

mvaivre commented Aug 3, 2022

Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improves an already existing feature
Projects
None yet
Development

No branches or pull requests

2 participants