Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Release 1.4.0 #378

Closed
2 tasks done
LeeAlephium opened this issue Sep 28, 2022 · 13 comments
Closed
2 tasks done

Release 1.4.0 #378

LeeAlephium opened this issue Sep 28, 2022 · 13 comments
Assignees
Labels
blocker An issue that blocks the next release

Comments

@LeeAlephium
Copy link
Contributor

LeeAlephium commented Sep 28, 2022

Modify this description to add or check off tasks needed to release 1.4.0.

Non-blockers should be their own issues.

Testing spreadsheet

Issues to be resolved found from release testing:

I think this covers everything (I derived it from our commit history), let me know / edit the list:

  • Internationalization support, with French as the first new language
  • Accessibility support: the entire application can be navigated with a keyboard and screen reader
  • Upgrade to use new network services (1.8 explorer and 1.4.5 Alephium node)
  • A refresh of the underlying dependencies
  • Redesign of how transactions are presented
    • Transactions between addresses of the same wallet are now condensed into one "Move" transaction
  • Addresses over the entire application can be copied
  • Lock times are now supported
    • Indicated with a lock beside the amount sent / received
    • When lock time passes the lock disappears
  • The window theme syncs with the application theme
  • Custom scrollbar to match across systems
  • Misc. UI updates (address badges, ellipsed addresses, toggle sections)
@LeeAlephium LeeAlephium added the blocker An issue that blocks the next release label Sep 28, 2022
@LeeAlephium
Copy link
Contributor Author

LeeAlephium commented Sep 28, 2022

@nop33 without fail I've forgotten once again how to test sweeps - could you describe how they're done and we can save it somewhere for the future and I can do it?


I noticed this when transitioning from online to offline mode (after amounts are loaded) - everything turns to "zero" (probably intentional):

1664391275

Is this something we want to change in the future?

@LeeAlephium
Copy link
Contributor Author

You can delete an account but if it's selected it stays selected:

recording-2022-09-28_15.02.22.mp4

@LeeAlephium
Copy link
Contributor Author

LeeAlephium commented Sep 28, 2022

There's an orange border around copy icons when in an active state (and probably others, check when fixing):

recording-2022-09-28_15.07.35.mp4

@nop33
Copy link
Member

nop33 commented Sep 28, 2022

@nop33 without fail I've forgotten once again how to test sweeps - could you describe how they're done and we can save it somewhere for the future and I can do it?

I guess you mean how to test the consolidation feature through the send modal. You need to use the Swagger UI to build a couple of TX with many many outputs towards one of your addresses, so that when you try to send those funds back you'll get the consolidation modal poping up before sending the tx.

@LeeAlephium
Copy link
Contributor Author

"Optional passphrase" text is too high / not enough spacing between the fields:

1664395012

@LeeAlephium
Copy link
Contributor Author

An example of the incorrect amount calculation manifesting:

1664395426

It says "0.001" locked but none is supposedly sent (I did send 0.001, not 0 + fee...)

@LeeAlephium
Copy link
Contributor Author

On the wallet import screen, it requests the recovery phrase, but also says to write it down... This doesn't make sense since it'll already be written or stored somewhere since they are importing it.

1664396948

@LeeAlephium
Copy link
Contributor Author

LeeAlephium commented Sep 28, 2022

Accessibility issues:

  • Pressing enter on passphrase toggle when wallet and password are entered submits the form instead of expanding the section
  • Toggling the checkbox for "I understand that..." and then going to the passphrase input and typing doesnt work
  • Copy buttons are being tabbed to in the transaction rows
  • Double text being spoken (hidden text and the visible text) in the transaction rows
  • Offline mode icon not tabbable (should be so blind user can listen to screen reader and know wallet is offline...)

Everything else is more or less fine

@LeeAlephium
Copy link
Contributor Author

LeeAlephium commented Sep 28, 2022

@nop33 @mvaivre please add what you think which of these are blockers to the issue description and the rest (who knows, maybe all) can be created as separate issues

@LeeAlephium
Copy link
Contributor Author

I can't seem to invoke the consolidate modal - I created a huge transaction twice and it wasn't enough apparently? And when sending funds within the wallet it hung for loooong time and eventually showed '???' for the balance:

1664400960

This was the data which I sent to /wallets/:wallet-name/transfer

@nop33
Copy link
Member

nop33 commented Sep 29, 2022

Thanks a lot @LeeAlephium for your thorough tests!

This format of reporting issues is not very convenient for discussing them. It'd be useful if there were discussion threads like in PRs (I know, not possible in issues).

I propose we create issues for each one of the obvious ones. When unsure, just ping on Slack:

image

@mvaivre
Copy link
Member

mvaivre commented Sep 29, 2022

Great testing session, thanks a lot @LeeAlephium! 🙏
I'll create related issues.

@nop33
Copy link
Member

nop33 commented Oct 3, 2022

Based on @LeeAlephium's changelog, I've updated it to add some more:

## 🎉 New features
- Transaction amounts can be locked until a specified date time #358
- Internationalization support, with French as the first new language #272
- Display pending sent transactions on app launch #323

## 🤝 Feedback from community
- Addresses can now be copied by hovering over their label #334 #302
- The application theme syncs with the OS theme #109

## ♿️ Accessibility
- The entire application can be navigated with a keyboard and screen reader #191

## 🎨 UI updates
- Improved display of transaction table rows #301
- Transactions between addresses of the same wallet are now condensed into one "Move" transaction #367
- Improved display of address labels #350
- Transaction details were extended to include lock time #358
- Custom scrollbar to match across systems #313
- Update expandable sections with a toggle button
- Update theme colors

## 🐛 Bug fixes
- Refresh list of available wallets once a wallet gets deleted #306

## Other updates
- Using new mainnet and testnet services #363
- Use consistent wording when mentioning the recovery phrase #315
- Updated dependencies

@nop33 nop33 closed this as completed Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocker An issue that blocks the next release
Projects
None yet
Development

No branches or pull requests

3 participants