Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$spacing not overwriteable #19

Open
robinsandborg opened this issue Jun 24, 2016 · 2 comments
Open

$spacing not overwriteable #19

robinsandborg opened this issue Jun 24, 2016 · 2 comments

Comments

@robinsandborg
Copy link
Member

$spacing is defined as:
$spacing: $line-height;

If we try to overwrite $spacing in the settings, it will revert to whatever $line-height is. Should we add a !default to this one?

@macbruker
Copy link

I think that would be nice.

I am thinking it would be nice to disconnect $spacing and $line-height completely. It makes sense for those cases where you are working with unitless values for line-height.

@robinsandborg
Copy link
Member Author

I think it’s a useful default though; having ´$spacing´ and ´$line-height´ set to the same number should contribute to a good vertical rythm.

The ´font-size´ include converts the pixel value of $line-height to a unitless value, so no worries there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants