Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter improvements #85

Open
alex-taxiera opened this issue Sep 8, 2020 · 0 comments
Open

Parameter improvements #85

alex-taxiera opened this issue Sep 8, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@alex-taxiera
Copy link
Owner

Right now command parameters are just lame strings you can pass to display in the help command.

Params probably need to be expanded to objects with a few props such as:

  • name
  • description
  • mandatory (important!)
  • etc?

These can then be used in the help command.

What's mandatory all about?

This will help us do command parameter length validation, need to be careful with it though. It should be illegal to have any mandatory params after an optional one.

When checking required parameter length, we only need to care about the number of mandatory params, this could be set on the Command itself within the constructor (as could the previously mentioned validation).

@alex-taxiera alex-taxiera added the enhancement New feature or request label Sep 8, 2020
@alex-taxiera alex-taxiera added this to the 3.2 milestone Sep 8, 2020
@alex-taxiera alex-taxiera self-assigned this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant