MessageRouter::send() does not take the m_connectionMutex

[lrvega]

Hello,

I was wondering if MessageRouter::send() should actually take the m_connectionMutex lock? When inspecting other methods in the class, when m_activeTransport is read and/or queried, m_connectionMutex is locked (recursively, but it is locked).

Thanks,
Luis

[scotthea-amazon]

Hello lrvega,
Yes, that is correct. Thank you very much for pointing out this bug! We have a fix in progress that holds the lock just long enough to copy the shared pointer. It is along the following lines:

 void MessageRouter::send(std::shared_ptr<MessageRequest> request) {
     auto task = [this, request]() {
-        if (m_activeTransport && m_activeTransport->isConnected()) {
-            m_activeTransport->send(request);
+        std::unique_lock<std::recursive_mutex> lock{m_connectionMutex};
+        auto transport = m_activeTransport;
+        lock.unlock();
+        if (transport) {
+            transport->send(request);
         }
     };
     m_sendExecutor->submit(task);
 }

Thank you again!
-SWH

[JamieMeyers]

Hi @lrvega,

Sorry for the delay. This will go out in the next release.

Thanks,
Jamie

[scotthea-amazon]

This fix has been pushed in version 0.4.1.