Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Direct DB connection" config isn't stay enabled on 3.10.2 #731

Closed
fernandolcx opened this issue Apr 26, 2019 · 10 comments
Closed

"Direct DB connection" config isn't stay enabled on 3.10.2 #731

fernandolcx opened this issue Apr 26, 2019 · 10 comments

Comments

@fernandolcx
Copy link

Describe the bug
The datasource validates and saves successfully, but when refreshing the page the "Enable" switch from Direct DB connection appears turned off.

Screenshots
image

saved.
Then F5:

image

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
6.1.4 4.2.1 3.10.2
@and111016
Copy link

Confirm same issue
Grafana - Grafana v5.4.2 (d812109)
Zabbix - 3.4.15
Grafana-Zabbix Plugin - 3.10.1, 3.10.2

On 3.10.0 work

@kaeltis
Copy link

kaeltis commented May 1, 2019

Can confirm the same with MySQL

Grafana - v6.1.6 (cf9cb45)
Zabbix - 4.2.1.
Grafana-Zabbix Plugin - 3.10.2

@fernandolcx fernandolcx changed the title "Direct DB connection" config don't stick with PostgreSQL on 3.10.2 "Direct DB connection" config don't stick on 3.10.2 May 1, 2019
@DrKomtur
Copy link

DrKomtur commented May 6, 2019

same for PSQL
Grafana - v6.0.2
Zabbix - 4.0.7
Plugin - 3.10.2

@anthonysomerset
Copy link

same for InfluxDB FYI

@silvermoon-h
Copy link

Yes, some issue.
Grafana - v6.1.6
Zabbix - 4.2.1
grafana-zabbix - 3.10.2

@Positronico
Copy link

Same here. Noticed when trying to add the same DB connection on a second Org. The first one (create a while ago) is still working.

Grafana - v6.1.6
Zabbix - 4.2.1
grafana-zabbix - 3.10.2

@anthonysomerset
Copy link

so i have a temp workaround that seems to work

manually edit the row in the data_source table and edit the json_data column

NOTE: the zabbix api user/pass is in this field so only amend the dbConnectionDatasourceName and
dbConnectionRetentionPolicy fields as required

example (mysql/PGSQL):

{"addThresholds":false,"alerting":false,"alertingMinSeverity":3,"dbConnectionDatasourceId":null,"dbConnectionEnable":true, "dbConnectionDatasourceName":"Zabbix-PostgreSQLTSDB", "dbConnectionRetentionPolicy":"","disableReadOnlyUsersAck":true,"keepCookies":[],"oauthPassThru":false,"password":"xxxxxxxxx","trends":true,"trendsFrom":"7d","trendsRange":"4d","username":"xxxxxxxxx","zabbixVersion":4}

InfluxDB:

{"addThresholds":false,"alerting":false,"alertingMinSeverity":3,"dbConnectionDatasourceId":null,"dbConnectionEnable":true, "dbConnectionDatasourceName":"Zabbix-InfluxDB", "dbConnectionRetentionPolicy":"SomeRetentionPolicy","disableReadOnlyUsersAck":true,"keepCookies":[],"oauthPassThru":false,"password":"xxxxxxxxx","trends":true,"trendsFrom":"7d","trendsRange":"4d","username":"xxxxxxxxx","zabbixVersion":4}

Then you can view the data source in the GUI to verify the change worked just don't save it again via the GUI

@tiago-cruz-movile
Copy link

Same thing here, env:

  • zabbix-server-mysql-4.0.5-1.el7.x86_64
  • grafana-6.2.0-1.x86_64
  • zabbix plugin for grafana version 3.10.2

@babarbobar
Copy link

Same while testing with InfluxDB (with Effluence):
Zabbix 4.0
Grafana 5.4.2
Plugin 3.10.2

@alexanderzobnin alexanderzobnin modified the milestones: 3.11, 3.10.3 Jul 26, 2019
@alexanderzobnin alexanderzobnin changed the title "Direct DB connection" config don't stick on 3.10.2 "Direct DB connection" config isn't stay enabled on 3.10.2 Jul 26, 2019
@tolsadus
Copy link

What the feature broken, or just the UI? Thanks for the quick fix! 👍

sapajune pushed a commit to digiaiiris/grafana-zabbix that referenced this issue Aug 14, 2019
timyllym pushed a commit to digiaiiris/grafana-zabbix that referenced this issue Jun 5, 2020
* Iiris version of Grafana-Zabbix plugin

* fix direct DB connection datasource config, closes grafana#731

* IISCRUM-1293 Change panel default settings

* IISCRUM-1319 Add title for no data

* hotfix/IISCRUM-1324 (#4)

* IISCRUM-1324 Change selector directive name

* IISCRUM-1324 Add one conditional

Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
Co-authored-by: Sami Pajunen <sami.pajunen@digia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests