Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITEM.VALUE acts like ITEM.LASTVALUE in annotations #891

Closed
Akint opened this issue Feb 13, 2020 · 1 comment
Closed

ITEM.VALUE acts like ITEM.LASTVALUE in annotations #891

Akint opened this issue Feb 13, 2020 · 1 comment

Comments

@Akint
Copy link

Akint commented Feb 13, 2020

Describe the bug
When {ITEM.VALUE} macros is used in a trigger name and annotations of this trigger occurs multiple times on a single graph, the macros is resolved like {ITEM.LASTVALUE} on every occurrence.
As you can see on the screenshot below, annotation text is always too large: 5 for a trigger with condition item.last() > 1 and title too large: {ITEM.VALUE}.
old

Expected behavior
When possible, the historical (at-the-time-of-event) value should be seen in annotation text.
The screenshot below is a spoiler of how it works after my fix.
expected

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
6.6.1 4.0.17 3.10.5

P.S. May be a duplicate of #396, but the latter was never resolved.

Akint added a commit to Akint/grafana-zabbix that referenced this issue Feb 13, 2020
@alexanderzobnin
Copy link
Collaborator

Hi! Yes, it's better to use event name for annotations, like you did in your commit, good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants