Bug: Maximum call stack size exceeded #51

luislhl · 2021-02-25T18:13:23Z

Describe the bug
I'm getting this stack-trace when running the tool in my project

> typescript-coverage-report

RangeError: Maximum call stack size exceeded
    at getRootNames (/home/luislhl/Workspace/pareto/quantic-spa/node_modules/type-coverage-core/dist/tsconfig.js:148:15)
    at async Object.getProjectRootNamesAndCompilerOptions (/home/luislhl/Workspace/pareto/quantic-spa/node_modules/type-coverage-core/dist/tsconfig.js:18:23)
    at async Object.lint (/home/luislhl/Workspace/pareto/quantic-spa/node_modules/type-coverage-core/dist/core.js:17:44)

To Reproduce
Just running typescript-coverage-report without any extra options.

Expected behaviour
I expected the report to be generated

Environment

Tool version: 0.5.0
OS: Fedora Linux
Node version: v12.18.3
Npm version: 6.14.6

Additional context
Add any other context about the problem here.

The text was updated successfully, but these errors were encountered:

alexcanessa · 2021-02-26T12:29:13Z

Hmm I wonder how many files it's trying to run.

Interesting it would mean that we'd have to change the approach and have separate builds.

Could you try and run it with this:

--max-old-space-size=8192

sanjaypojo · 2021-03-31T20:13:30Z

Experiencing the same issue on a maxed out macbook pro.

--max-old-space-size=8192

Doesn't seem to recognize this flag. Output: unknown option '--max-old-space-size=8192'

EDIT: I tried running NODE_OPTIONS=--max-old-space-size=8192 typescript-coverage-report and get Maximum call stack size exceeded

alexcanessa · 2021-03-31T20:23:20Z

@sanjaypojo could you try to run the package that validates the coverage (the one this package is built on) on your amount of files?

I'm trying to understand where the problem is.

https://github.com/plantain-00/type-coverage

sanjaypojo · 2021-03-31T20:27:46Z

Hey @alexcanessa yes, I get the same error using type-coverage directly. The repo I'm running it on is pretty large (500+ files and 50+ dependencies)

alexcanessa · 2021-03-31T20:55:56Z

@sanjaypojo I've created an issue in that repo. I'll have a look myself too. Thanks for raising this.

alexcanessa · 2021-03-31T20:56:18Z

@all-contributors add @sanjaypojo for bugs

allcontributors · 2021-03-31T20:56:26Z

@alexcanessa

I've put up a pull request to add @sanjaypojo! 🎉

alexcanessa · 2021-03-31T20:57:23Z

@all-contributors add @luislhl for bugs

allcontributors · 2021-03-31T20:57:31Z

@alexcanessa

I've put up a pull request to add @luislhl! 🎉

sanjaypojo · 2021-03-31T21:00:18Z

Awesome @alexcanessa, happy to help with debugging / trying again any time!

plantain-00 · 2021-04-02T10:57:16Z

If I add console.info(process.env.NODE_OPTIONS) in type-coverage js code, execute NODE_OPTIONS=--max-old-space-size=8192 type-coverage, I can get:

$ NODE_OPTIONS=--max-old-space-size=8192 type-coverage
--max-old-space-size=8192

So NODE_OPTIONS should works.
From the error stack, it seems caused by recursive function call, can you provide a minimal reproduce repo, or add some js code to debug which function and why it is recursive.

plantain-00 · 2021-04-02T12:10:58Z

And it seems it errored when just finding tsconfig.json, so maybe just providing the tsconfig.json and it's extendsed tsconfig.json is enough to reproduce.

luislhl · 2021-04-09T02:03:45Z

@plantain-00 , I tried debugging this.
The problem seems to be related to the glob lib used in this section of tsconfig.js:

function globAsync(pattern, ignore, cwd) {
    return new Promise((resolve, reject) => {
        console.log('globAsync', pattern, ignore, cwd);
        glob(pattern, { ignore, cwd }, (error, matches) => {
            console.log('glob callback');
            if (error) {
                reject(error);
            }
            else {
                resolve(matches);
            }
        });
    });
}

This glob callback is never printed. In the meantime, glob lib is stuck scanning/processing a lot of folders, including all folders inside node_modules.

The other console.log prints this line:

globAsync {/home/luislhl/Workspace/pareto/platform-spa/**/*.ts,/home/luislhl/Workspace/pareto/platform-spa/**/*.tsx,/home/luislhl/Workspace/pareto/platform-spa/**/*.js} [ 'node_modules', 'public', 'static' ] .

So it seems to be passing node_modules to be ignored, but glob isn't really ignoring it somehow.

Then, I modified the code to force passing an absolute path of node_modules, like this:

function globAsync(pattern, ignore, cwd) {
    return new Promise((resolve, reject) => {
        console.log('globAsync', pattern, ignore, cwd);
        glob(pattern, { ignore: ['/home/luislhl/Workspace/pareto/platform-spa/node_modules/**', 'public/**', 'static/**'], cwd }, (error, matches) => {
            console.log('glob callback')
            if (error) {
                reject(error);
            }
            else {
                resolve(matches);
            }
        });
    });
}

After this, the glob callback was called in no time at all.

So maybe it's just a question of adjusting the options passed to glob?

However, this still didn't solve all my problems, since I'm now getting an Out of Memory error.
But I still didn't debug this one, will try to do it when I have some more time.

P.S: I was running typescript-coverage-report to debug this, so I'm not sure yet if this memory problem would happen when running type-coverage directly.

<--- Last few GCs --->

[413331:0x59dc0c0]   133527 ms: Mark-sweep (reduce) 2041.1 (2050.8) -> 2040.1 (2052.1) MB, 2217.6 / 0.0 ms  (average mu = 0.129, current mu = 0.012) allocation failure scavenge might not succeed
[413331:0x59dc0c0]   135765 ms: Mark-sweep (reduce) 2041.2 (2051.1) -> 2040.1 (2052.1) MB, 2185.6 / 0.0 ms  (average mu = 0.077, current mu = 0.023) allocation failure scavenge might not succeed


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0xa04200 node::Abort() [node]
 2: 0x94e4e9 node::FatalError(char const*, char const*) [node]
 3: 0xb7978e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xb79b07 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xd34395  [node]
 6: 0xd34f1f  [node]
 7: 0xd42fab v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 8: 0xd46b6c v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
 9: 0xd1524b v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [node]
10: 0x105b23f v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [node]
11: 0x1401219  [node]

plantain-00 · 2021-04-09T12:32:34Z

type-coverage v2.17.1 should fix the glob issue.

alexcanessa · 2021-04-09T14:12:26Z

Ok I'll update type-coverage-core then and keep you posted.

alexcanessa · 2021-04-10T14:10:03Z

This bug should be fixed in v0.5.1. @sanjaypojo are you able to test and see if it works?

sanjaypojo · 2021-04-13T04:41:45Z

Tested and works like a charm 💯 Thanks @alexcanessa 🙌🏽

alexcanessa · 2021-04-13T17:06:02Z

Thanks @plantain-00!

harshmaur · 2021-12-23T16:08:58Z

I still get this issue.

RangeError: Maximum call stack size exceeded
    at getBaseConstraintOfType (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:53240:41)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:37)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)
    at getTypeFacts (/node_modules/typescript-coverage-report/node_modules/typescript/lib/typescript.js:62711:24)

Any ideas?

I am using it with a next.js project. It works fine on create react app project.

alexcanessa · 2021-12-23T17:05:50Z

@harshmaur and I believe you're using the latest version of the tool?

harshmaur · 2021-12-23T17:19:45Z

Yes. 0.6.1 actually.

alexcanessa · 2021-12-23T17:24:00Z

@harshmaur could you try with 0.6.2 please?

titanium-cranium · 2022-11-08T01:08:25Z

Getting this same error on 0.6.4

RangeError: Maximum call stack size exceeded
    at getRootNames (/<root path>/node_modules/type-coverage-core/dist/tsconfig.js:179:15)
    at async getProjectRootNamesAndCompilerOptions (/<path>/node_modules/type-coverage-core/dist/tsconfig.js:19:23)
    at async Object.lint (/<root path>/node_modules/type-coverage-core/dist/core.js:17:44)

luislhl added the bug Something isn't working label Feb 25, 2021

alexcanessa self-assigned this Feb 26, 2021

alexcanessa added help wanted Extra attention is needed and removed bug Something isn't working labels Mar 1, 2021

alexcanessa added bug Something isn't working and removed help wanted Extra attention is needed labels Mar 31, 2021

alexcanessa mentioned this issue Mar 31, 2021

Maximum call stack size exceeded plantain-00/type-coverage#89

Closed

allcontributors bot mentioned this issue Mar 31, 2021

docs: add sanjaypojo as a contributor #53

Merged

allcontributors bot mentioned this issue Mar 31, 2021

docs: add luislhl as a contributor #54

Merged

alexcanessa added this to the v0.5.1 milestone Apr 9, 2021

alexcanessa mentioned this issue Apr 10, 2021

Update ts core #55

Merged

alexcanessa closed this as completed in #55 Apr 10, 2021

alexcanessa mentioned this issue Jun 3, 2021

Bug: Can't run the tool #66

Closed

titanium-cranium mentioned this issue Nov 8, 2022

Bug: Maximum call stack size exceeded #99

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: Maximum call stack size exceeded #51

Bug: Maximum call stack size exceeded #51

luislhl commented Feb 25, 2021

alexcanessa commented Feb 26, 2021

sanjaypojo commented Mar 31, 2021 •

edited

Loading

alexcanessa commented Mar 31, 2021

sanjaypojo commented Mar 31, 2021 •

edited

Loading

alexcanessa commented Mar 31, 2021

alexcanessa commented Mar 31, 2021 •

edited

Loading

allcontributors bot commented Mar 31, 2021

alexcanessa commented Mar 31, 2021

allcontributors bot commented Mar 31, 2021

sanjaypojo commented Mar 31, 2021

plantain-00 commented Apr 2, 2021

plantain-00 commented Apr 2, 2021

luislhl commented Apr 9, 2021 •

edited

Loading

plantain-00 commented Apr 9, 2021

alexcanessa commented Apr 9, 2021 •

edited

Loading

alexcanessa commented Apr 10, 2021

sanjaypojo commented Apr 13, 2021

alexcanessa commented Apr 13, 2021

harshmaur commented Dec 23, 2021 •

edited

Loading

alexcanessa commented Dec 23, 2021

harshmaur commented Dec 23, 2021

alexcanessa commented Dec 23, 2021

titanium-cranium commented Nov 8, 2022

Bug: Maximum call stack size exceeded #51

Bug: Maximum call stack size exceeded #51

Comments

luislhl commented Feb 25, 2021

alexcanessa commented Feb 26, 2021

sanjaypojo commented Mar 31, 2021 • edited Loading

alexcanessa commented Mar 31, 2021

sanjaypojo commented Mar 31, 2021 • edited Loading

alexcanessa commented Mar 31, 2021

alexcanessa commented Mar 31, 2021 • edited Loading

allcontributors bot commented Mar 31, 2021

alexcanessa commented Mar 31, 2021

allcontributors bot commented Mar 31, 2021

sanjaypojo commented Mar 31, 2021

plantain-00 commented Apr 2, 2021

plantain-00 commented Apr 2, 2021

luislhl commented Apr 9, 2021 • edited Loading

plantain-00 commented Apr 9, 2021

alexcanessa commented Apr 9, 2021 • edited Loading

alexcanessa commented Apr 10, 2021

sanjaypojo commented Apr 13, 2021

alexcanessa commented Apr 13, 2021

harshmaur commented Dec 23, 2021 • edited Loading

alexcanessa commented Dec 23, 2021

harshmaur commented Dec 23, 2021

alexcanessa commented Dec 23, 2021

titanium-cranium commented Nov 8, 2022

sanjaypojo commented Mar 31, 2021 •

edited

Loading

sanjaypojo commented Mar 31, 2021 •

edited

Loading

alexcanessa commented Mar 31, 2021 •

edited

Loading

luislhl commented Apr 9, 2021 •

edited

Loading

alexcanessa commented Apr 9, 2021 •

edited

Loading

harshmaur commented Dec 23, 2021 •

edited

Loading