Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support libbz2-rs-sys #110

Merged

Conversation

folkertdev
Copy link
Collaborator

Adds a feature flag that uses libbz2-rs-sys instead of bzip2-sys. The libbz2-rs-sys crate is a pure rust translation/implementation of stock bzip2. It is 100% compatible with stock bzip2.

Some notes:

  • Cross-compilation (e.g. to wasm) should be much easier than with the C FFI
  • Rust code is always linked statically (until we get a stable ABI, which is not close)
  • When used as a rust crate, the rust global allocator is used for all memory allocation by default
  • Our MSRV is pretty high right now. We can try to drop that a bit but e.g. let else is really convenient. The MSRV is unchanged with default settings.

I've not yet added any documentation (perhaps even the static feature flag deserves a mention somewhere). I've also not adjusted CI. Let me know what you want to see there (if anything).

@alexcrichton alexcrichton merged commit b397f2a into trifectatechfoundation:master Dec 5, 2024
9 checks passed
@alexcrichton
Copy link
Collaborator

Thanks!

Also if you'd like I'd be happy to add you as a maintainer of this crate as well (or transfer ownership, I haven't worked on it in quite awhile at this point)

@folkertdev
Copy link
Collaborator Author

Cool! @trifectatechfoundation would be happy to adopt and maintain bzip2-rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants