Support Visual Studio 2019. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think bumping the required cmake version is pretty reasonable as well, as it's at least a year old and shouldn't be too hard to update! Want to update this PR with an updated dependency on |
|
Sure. I'm very new to working with Rust stuff, so if I get something wrong, feel free to poke me to fix it. I tried shoving a local copy of harfbuzz-sys at the local version of cmake-rs, so I'm hoping it's working right now. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is correct according to the documentation for CMake 3.10 and newer.
It'd depend on rust-lang/cc-rs#386 or equivalent to work with the Vs16 symbol.
Fixes #70.