Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix socket support #297

Closed
jo2wan opened this issue Sep 7, 2019 · 4 comments
Closed

Unix socket support #297

jo2wan opened this issue Sep 7, 2019 · 4 comments

Comments

@jo2wan
Copy link

jo2wan commented Sep 7, 2019

Hi, I have a quick question,

It seems I have to add some options to build.rs to compile libcurl with unix socket support. Is it possible to pass those flags from a cargo.ml? I don't want to get the curl-sys locally with the two extra flags only.
Or maybe the way forward would be to create a specific feature.

@alexcrichton
Copy link
Owner

I believe this was added in #154, but feel free to comment here if that doesn't work!

@jo2wan
Copy link
Author

jo2wan commented Sep 9, 2019

it does not work, when you libcurl is not installed on the machine and when you compile it from build.rs.
I had to add the two following flags in the build.rs (which is not really convenient as I have to use a local version of curl-rust crate)

    cfg.define("USE_UNIX_SOCKETS", None)
        .define("HAVE_SYS_UN_H", None);

@alexcrichton
Copy link
Owner

Ah ok, good to know! Want to send a PR with that update?

@sagebind
Copy link
Collaborator

This has now been added and published in version 0.4.31!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants