Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user properties not filtered in conf.yml #62

Closed
andyp1per opened this issue May 26, 2015 · 4 comments
Closed

user properties not filtered in conf.yml #62

andyp1per opened this issue May 26, 2015 · 4 comments
Labels

Comments

@andyp1per
Copy link
Contributor

I'm guessing you know this since the code is clearly broken. But user properties are not filtered properly.

if if set <my.prop>foo</my.prop> in the pom and put ${my.prop} in conf.yml and then invoke mvn with:
mvn -Dmy.prop=bar clean install then ${my.prop} will be expanded to foo rather than bar.

@andyp1per
Copy link
Contributor Author

You shouldn't be calling p.putAll(System.getProperties()); IMO - this has already been done for you when you get the project properties. At a minimum you should call this after getting the project properties

@alexec
Copy link
Owner

alexec commented May 26, 2015

Hi Andy,

Do you fancy becoming a contributor as you seem to know more about this than I do!

Alex

@alexec alexec added the bug label May 26, 2015
@alexec
Copy link
Owner

alexec commented May 26, 2015

Fixed in latest push.

@alexec alexec closed this as completed May 26, 2015
@andyp1per
Copy link
Contributor Author

Thanks, works! So many projects, too little time. I'm happy to create pull requests - but even happier when bug reports get actioned ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants