resolve .ts/.tsx/.d.ts first, and then fallback to @types/*

[JounQin]

No description provided.

[JounQin]

@alexgorbatchev @bradzacher Do you have any time to review this PR? It is really needed.

[rdsedmundo]

+1 for reviewing, really looking forward to having this.

[JounQin]

@rdsedmundo You can try yarn add -D eslint-import-resolver-typescript@JounQin/eslint-import-resolver-typescript#feat/resolve_dts temporarily.

[trevorblades]

Works like a charm with the alwaysFindTypes option. Thanks @JounQin! 👍

[Protectator]

Any news on a potential merge ?

[JounQin]

Hey guys, it seems @alexgorbatchev has 'disappeared' for a few months, or he just forgot this project, so I'm going to fork this repository and republish it as eslint-import-resolver-ts to npm. You can simply change your eslint config:

'import/resolver': {
- typescript: {
+ ts: {
    alwaysTryTypes: true,
  },
},

If anyone is interested, you can follow eslint-import-resolver-ts, PR welcome.

And I will not close this PR, in case @alexgorbatchev return.

[Protectator]

Great, thanks for taking the initiative.

[ljharb]

@JounQin if it's not too late, it's best to publish forks under a scope.

[trevorblades]

@ljharb @JounQin you should be able to unpublish NPM packages within 48 hours of them being published. Would the scoped name you're referring to be something like @jounqin/eslint-import-resolver-typescript?

[ljharb]

Yes, exactly.

[JounQin]

@ljharb scoped package shorthand is supported by eslint-plugin-import?

{
  "@rxts/typescript": {}
}

It's a bit long to me.

---

It tried @rxts/typescript, it seems it's not supported:

Resolve error: unable to load resolver "@rxts/typescript"

What means if we change to a scoped package, we have to use:

{
  "@rxts/eslint-import-resolver-typescript": {}
}

Seems bad to me.

Of course, if eslint-plugin-import supports short hand for scoped resolver, I will republish it a scoped package @rxts/typescript.

[ljharb]

i don’t believe we support a shorthand, but the priority imo shouldn’t be “what you have to copy and paste into your config file”, but rather “what will make it very clear this is a fork”

[JounQin]

@ljharb @trevorblades I'm not only going to fork it without other changes but also refactor, add new features and try to maintain it in the future.

Of course, if @alexgorbatchev return and accept, I can PR back.

Please help to review un-ts#10 if you don't mind.

[alexgorbatchev]

Sorry for MIA :( life...

[JounQin]

Welcome back @alexgorbatchev . So are you going to maintain this resolver in the future? I can PR back from my fork https://github.com/rx-ts/eslint-import-resolver-ts which has been refactored to be .ts based itself with a few new improvements, maybe.

[alexgorbatchev]

I think it would make sense to merge back. I can make you a collaborator on the repo. Would that work?

[JounQin]

@alexgorbatchev That would be great.

[alexgorbatchev]

Done

…

On Fri, Sep 27, 2019, 17:15 JounQin ***@***.***> wrote: @alexgorbatchev <https://github.com/alexgorbatchev> That would be great. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAQAYIIUR2JCOSZG4XKZFDQL2O3RANCNFSM4H4L4IEQ> .