Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CRA 3.3.0 #112

Closed
3 tasks
alexieyizhe opened this issue Nov 22, 2019 · 0 comments · Fixed by #123
Closed
3 tasks

Update to CRA 3.3.0 #112

alexieyizhe opened this issue Nov 22, 2019 · 0 comments · Fixed by #123
Labels
🧹 chore Documentation, cleanup, refactoring, etc effort: low

Comments

@alexieyizhe
Copy link
Owner

alexieyizhe commented Nov 22, 2019 •
edited
Loading

Right now, CRA doesn't include support for optional chaining and nullish coalescing, so I'm using a custom webpack config with babel and react-app-rewired.

CRA 3.3.0 should be released soon with support for both the above built in, and we should update and remove our own custom stuff.

  • Remove .babelrc
  • Remove config-overrides.js
  • Remove packages
    • react-app-rewired
    • @babel/plugin-proposal-optional-chaining
    • @babel/preset-typescript
    • babel-register
    • customize-cra
    • react-app-rewired
@alexieyizhe alexieyizhe added 🧹 chore Documentation, cleanup, refactoring, etc effort: low labels Nov 22, 2019
@alexieyizhe alexieyizhe mentioned this issue Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧹 chore Documentation, cleanup, refactoring, etc effort: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add website/careers link alexieyizhe/intern.plus
1 participant
@alexieyizhe