Thresholds wrongly triggering a notification

[alexdelprete]

Describe the bug
When setting thresholds, from what I interpret, if the values of the test are lower than thresholds for speed, and higher for ping, a notification should be created. Instead, I'm receiving notification for threshold every time, but test values do not hit those thresholds.

To Reproduce
Set threshold and do a test.

Expected behavior
I expect notifications to be fired only if test speed values are lower than thresholds or ping is higher.
Would also be good in the notification to describe which thresholds triggered it.

Screenshots

[stepanov1975]

Same issue here

[alexjustesen]

I'm planning on overhauling the event system this weekend (maybe, priority is going to be breweries). Currently is a little hacked together and won't scale well.

I like the idea of saying which threshold triggered as well so I'll be introducing that too.

[alexdelprete]

Drink a good beer for me too. Cheers. :)

[alexjustesen]

@alexdelprete needs a little more work but the PR below fixes the absolute notifications and the preview is up so you can see what per threshold notifications looks like #138.

thanks for the suggestion!

[alexdelprete]

So the notification will be for each specific threshold? great!

[alexjustesen]

So the notification will be for each specific threshold? great!

bingo

[alexdelprete]

Now that I think about it...I'll wait for the latest influxdb patches (I read your comments in the PR) to be merged so I can test both issues.

[stepanov1975]

Pulled latest version and the problem is still here

[alexdelprete]

Pulled latest version and the problem is still here

0.2.1 works for me. Did you recreate the container?

Anyway, more fixes to influx are coming.

[alexjustesen]

Pulled latest version and the problem is still here

Haven't done a release yet for that code. Currently sitting in PR #138 and will be probably a v0.3.0 tag

[alexdelprete]

Haven't done a release yet for that code. Currently sitting in PR #138 and will be probably a v0.3.0 tag

0.2.1 contained the first fix by @adamus1red, and it's working here:

fix sending data to influxdb by @adamus1red in #130

but 0.3.0 will be much better I bet. :)