-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique AppId for each app #14
Comments
I've added this feature in iOS. Will do it in Android later and submit a PR. |
@Emilios1995 Great! |
@Emilios1995 Can you please share your code for doing that? I want to be able to essentially allow |
@ProGoogler What do you mean by AppId? In library the purpose of AppId is to isolate different apps (of different vendors) from communication with each other with incompatible application-level protocols. |
@virl I assumed that AppId would be a unique identifier set by calling a function on NativeManager such as EDIT: Nevermind, I looked around a bit more closely and saw that |
@ProGoogler I’m the author of underlying native library. frameData is just packet that is sent in device-to-device connection and can have arbitrary contents. Underlying library have no notion of users, only connections. You can implement users abstraction on top of that, if you need. On native level, it is not possible to send arbitrary string during peer discovery without establishing connection, because BLE packets that is used for discovery have max size of only 20 bytes (with even less free space). |
@viri I noticed you carried some clout from viewing other issues but I kept getting confused by that notion because you're not assigned a contributor or collaborator title. XD You're right, I don't need to change anything for sending user abstractions because Excellent work by the way. For the past few days I've been so let down by the fact that Android and iPhone cannot communicate via Bluetooth, NFC, etc. Then recently I discovered Google Nearby but the RN bridge isn't mature enough yet. And then I discovered you guys, I'm super happy! Thank you. |
@ProGoogler I don’t have contributor title in this project because currently I have no relation to it other than the fact that this is community-driven react project that uses my library that is by itself proprietary commercial product (but with free binary version).
My library and this project (as I understand) currently don’t support Bluetooth communication between iOS and Android due to their OS restrictions. |
@viri That's so cool. I really like what you've done here. I am hoping to be able to use this library in production very soon. I just noticed that this library is missing one of those license documents. I have had a recent issue but I think I'll open up a different thread for that. Thank you for your commitment to solving this problem for us!! EDIT: Nevermind the question, I found the answer in your license:
|
Hello!
One of the users told me that in React bindings it is impossible to set AppId during configuration — although in native libraries it is possible.
Unique AppId allows discovery and communication to be isolated and non-interfering between different apps from different developers that use same library.
The text was updated successfully, but these errors were encountered: