Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License details missing #18

Open
jamesbursa opened this issue Jul 26, 2017 · 3 comments
Open

License details missing #18

jamesbursa opened this issue Jul 26, 2017 · 3 comments

Comments

@jamesbursa
Copy link

I can't find any details of the license for this repository. Is it open source and can a license be added please? https://help.github.com/articles/licensing-a-repository/

@jamesbursa
Copy link
Author

Here is a one possibility as a patch which adds an MIT license. Based on the git log, it would need agreement from @alexkendall, @thibmaek, and @iotashan. Thanks for considering it!

diff --git a/LICENSE b/LICENSE
new file mode 100644
index 00000000..9c90109c
--- /dev/null
+++ b/LICENSE
@@ -0,0 +1,23 @@
+MIT License
+
+Copyright (c) 2017 Alexander Harrison
+Copyright (c) 2017 Thibault Maekelbergh
+Copyright (c) 2017 iotashan
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
diff --git a/package.json b/package.json
index 8daafb7b..68eff120 100644
--- a/package.json
+++ b/package.json
@@ -4,6 +4,7 @@
   "private": false,
   "description": "Cross-platform bluetooth and wi-fi nearby proximity framework.",
   "author": "Alex Harrison alexkendall.harrison@gmail.com",
+  "license": "MIT",
   "repository": {
     "type": "git",
     "url": "https://github.com/alexkendall/react-native-bluetooth-cross-platform"

@alexkendall
Copy link
Owner

@jamesbursa I think we can go ahead and do this, but we will have to somehow add @virl

@virl
Copy link

virl commented Aug 7, 2017

@alexkendall Hello. As I understand, this is license for the bindings, not for the native library.
So I guess because I haven't wrote code for the bindings yet, there is no need to add me currently.

But because native library is separate commercial product, I think it will be good for the users to know that when reading your license or readme (so they will not confuse terms for the bindings and for underlying library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants