Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist the appointment price and currency for future use #1406

Open
cn-tools opened this issue Sep 2, 2023 · 6 comments
Open

Persist the appointment price and currency for future use #1406

cn-tools opened this issue Sep 2, 2023 · 6 comments

Comments

@cn-tools
Copy link

cn-tools commented Sep 2, 2023

It would be great if the price currently valid at the time of booking could be saved on the appointment. Any price adjustments can be better tracked so that the customer is not charged the wrong price.

@alextselegidis
Copy link
Owner

Hello!

This is a good idea.

I think in general it would make more sense in the future to store the customer info as well, as they may change in the future.

So we need to have the right information in the database for the time of booking.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@cn-tools
Copy link
Author

On which data do you think here?

I think the customer remains the same customer even if he moves somewhere else. That's why I'm not sure whether it's really necessary to save the customer's data on the appointment itself.

For me it makes more sence to save some infos from the booked service on the appointment directly.

@alextselegidis
Copy link
Owner

For example the customer data at the time of booking would be important info to keep, as those might change later on

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@stevenkissack
Copy link

@alextselegidis I am working on this in my fork as a pre-cursor to adding #710

I saw the requirement for these new fields in my personal use case:

appointment.total_cost - using "total" as there might be offers/deductions made. I could also call this billed_amount?
appointment.currency - currency at the time of booking

I'll allow the backend modal to set a custom total & currency but default to the selected service rates

Do you have any specific input before I try to upstream? 🙏

@alextselegidis
Copy link
Owner

Hello!

Thanks for posting this

Let's better name the fields:

  • price
  • currency

Make sure there's a migration for each one of them and update the model class accordingly

Also this should go to develop branch

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@alextselegidis alextselegidis changed the title save currently price to appointment Persist the appointment price and currency for future use Mar 25, 2024
@stevenkissack
Copy link

I'll update my local mirror to use appointment.price and open a PR for feedback today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants