Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secretaries didn't received appointments notification #262

Open
rankun203 opened this issue Dec 11, 2016 · 3 comments
Open

Secretaries didn't received appointments notification #262

rankun203 opened this issue Dec 11, 2016 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@rankun203
Copy link
Contributor

I have Receive Notification on in a secretary settings, the secretary are connected to a provider, but when I use another email to make an appointment to that specific provider, the secretary received no email.

Will secretaries receive appointments notification of connected providers?

@alextselegidis
Copy link
Owner

alextselegidis commented Dec 13, 2016

Hi, yeah this is a necessary setting. I wanted to implement this before but I guess it's just forgotten due to other task or feature implementations. Will mark it as a feature for an upcoming release.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Contact me in person!

@alextselegidis alextselegidis added the enhancement New feature or request label Dec 13, 2016
@alextselegidis alextselegidis self-assigned this Jan 28, 2018
@lucacalcaterra
Copy link

Hi! Any news on this issue ? Thanks ...

@RaphaelWimmer
Copy link

RaphaelWimmer commented Feb 17, 2021

The logic seems to be wrong here:

if (in_array($provider['id'], $secretary['providers']))
{
continue;
}

It should be inverted so that we do not skip the email if the provider is in the secretary's list of providers:

if (! in_array($provider['id'], $secretary['providers']))
                {
                    continue;
                }

(I changed this in my installation, and now the secretary recevives email.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants