Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google meets support #86

Open
yayashn opened this issue Apr 24, 2024 · 4 comments
Open

Add google meets support #86

yayashn opened this issue Apr 24, 2024 · 4 comments

Comments

@yayashn
Copy link

yayashn commented Apr 24, 2024

At work I have to be in meetings, with my camera on & watch someone share their screen to outline goals.

Unfortunately there's always women there, so it would be very convenient if this can detect live google meets videos.

@yayashn
Copy link
Author

yayashn commented May 17, 2024

If @alganzory or any contributor can give a high level overview on how to achieve this I can contribute to this feature inshaallah.

@alganzory
Copy link
Owner

@yayashn thanks for raising this,
I believe the problem comes from the lack of a 'src' property on the video element in gmeet
image

If you'd like to take a look before I get time to do so, the logic for this is in the observeNode function in src/modules/observers.js file

@alganzory
Copy link
Owner

Basically there's an if condition there that skips elements that have no 'src' attribute, if you comment it out, your google meet video will get scanned, but I can't just remove that if statement because I probably added it there for a reason that I can't quite recall at the moment 😅, I'll try to see if I can remove that condition but that will need some testing for edge cases that I, again, don't quite remember at the moment, if you wanna do some testing on that please let me know what you find

@yayashn
Copy link
Author

yayashn commented May 26, 2024

#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants