Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagram editor breaks hyperlinks #9

Closed
teunvink opened this issue Apr 18, 2019 · 9 comments
Closed

diagram editor breaks hyperlinks #9

teunvink opened this issue Apr 18, 2019 · 9 comments

Comments

@teunvink
Copy link

I'm testing the version mentioned in #7
One thing I noticed that changed since the previous version I used (which was installed with grafana-cli) is that hyperlinks on objects in the diagram don't work anymore.

For example:
<mxGraphModel dx="492" dy="577" grid="1" gridSize="10" guides="1" tooltips="1" connect="1" arrows="1" fold="1" page="0" pageScale="1" pageWidth="827" pageHeight="1169" math="0" shadow="0"> <root> <mxCell id="0"/> <mxCell id="1" parent="0"/> <UserObject label="" link="https://grafana.com" id="2"> <mxCell style="rounded=0;whiteSpace=wrap;html=1;" vertex="1" parent="1"> <mxGeometry x="120" y="40" width="120" height="50" as="geometry"/> </mxCell> </UserObject> </root> </mxGraphModel>

used to work in the old version, now the hyperlink isn't clickable anymore. Does the minify/compress function perhaps break this? Looking at the generated HTML, I don't see a hyperlink anymore in the SVG.

@algenty
Copy link
Owner

algenty commented Apr 22, 2019

Hi teunvink,
Thx for your feedback
I'm going to invest this. i think i know the problem.

@algenty
Copy link
Owner

algenty commented Apr 29, 2019

Hi @teunvink,
Can you test this alpha, test in progress.
Be carefull, 0.2 not compatible, migrate process in progress for next release.
Next versions will compatible with 0.3
agenty-flowcharting-panel-0.3.0-SNAPSHOT.zip

[0.3.0] - 2019-05-01

Added

- Full review of code (ES6 Class mode)
- Unit test with jest to increase quality
- Fill/text/stoke rules on the same object
- Mapping selector helper
- Icon overlay state
- Implemented Text on state
- new inspect Tab with :
  - Renamer ID (double click on ID)
  - State status
  - Debug mode
- Custom Link Mapping.

Fixed

- Substring replace on text (Issue #8)
- Editor object not found Exception (Issue #1)
- Original Link 

Best reguards,
Arnaud

@teunvink
Copy link
Author

Hi Arnaud, thanks for the work. Unfortunately, this snapshot doesn't seem to work properly. All existing panels seem to have lost their layout, they are replaced by the default diagram provided by the plugin. I reverted back to the previous version since we rely on these diagrams for network monitoring.

@algenty
Copy link
Owner

algenty commented Apr 30, 2019

Ok, thx for this feedback.
0.3 have many breaking changes.
What is your version ? 0.2 o 0.2.5 ?
Migrate process not work correctly at this time but for a new panel, it work.

@algenty
Copy link
Owner

algenty commented Apr 30, 2019

ok, i know why, i'll correct it

@teunvink
Copy link
Author

teunvink commented May 1, 2019

Ok great, let me know if you want me to test something.

@algenty
Copy link
Owner

algenty commented May 1, 2019

Try it 0.3.0 in
https://github.com/algenty/flowcharting-repository/tree/master/archives

@teunvink
Copy link
Author

teunvink commented May 1, 2019

Thanks for the quick update! The new snapshot seems to work ok. Diagrams are ok and hyperlinks work again.

@algenty
Copy link
Owner

algenty commented May 1, 2019

you'r welcome
thx for this back, its me, i thank you to test alpha.

@algenty algenty closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants