Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use no_delay on the TcpStream #390

Closed
whyCPPgofast opened this issue May 22, 2021 · 1 comment · Fixed by #465
Closed

use no_delay on the TcpStream #390

whyCPPgofast opened this issue May 22, 2021 · 1 comment · Fixed by #465

Comments

@whyCPPgofast
Copy link

Hi,

https://doc.rust-lang.org/std/net/struct.TcpStream.html#method.set_nodelay

This is basically a default for most modern http clients since it reduces latency of sending bytes.

I was going through the stream.rs file but I'm not sure how to implement it and make a pull request so I decided to open this issue sorry about that.

@jsha
Copy link
Collaborator

jsha commented May 23, 2021

Some references:

curl sets nodelay by default
reqwest sets nodelay by default
Go sets nodelay by default on all TCP connectiosn

I'm in favor of implementing. Let's build it on top of #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants