Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Manage active wallet #848

Open
wants to merge 11 commits into
base: development
Choose a base branch
from

Conversation

IYTEC
Copy link
Contributor

@IYTEC IYTEC commented Oct 31, 2022

ℹ Overview

  • Set the newly connected wallet as active wallet
  • Remember selected wallet after refresh

📝 Related Issues

🔐 Acceptance:

  • yarn test passes

@IYTEC IYTEC requested a review from atrefonas October 31, 2022 11:00
@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
algodex-react-dev ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 11:47AM (UTC)

@atrefonas
Copy link
Contributor

I don't think the wallet code is manageable right now as it is too complex and error-prone. It all needs to be switched to a useReducer to make any changes.

Copy link
Contributor

@atrefonas atrefonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the wallet code needs to be changed to a useReducer. The hooks all need to be brought into algodex-react as well. The state changes need to happen in a single location. Otherwise too risky to make any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants