Skip to content

Commit a57612a

Browse files
authored
fix(scripts): skip invalid semver (#4284)
1 parent 07ce2f8 commit a57612a

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

Diff for: scripts/release/__tests__/versionsHistory.test.ts

+36
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,42 @@ describe('no new releases', () => {
3838
});
3939
});
4040

41+
it('skips invalid versions', () => {
42+
const versions = generateLanguageVersionsHistory(
43+
[
44+
'1.2.4 Thu Dec 28 15:48:25 2023 +0000',
45+
'1.1 Thu Dec 28 15:48:25 2023 +0000',
46+
'1.2.5 Tue Jan 2 14:17:11 2024 +0000',
47+
'1.2.6 Tue Jan 2 15:26:06 2024 +0000',
48+
'1.2.7 Thu Jan 4 15:09:11 2024 +0000',
49+
],
50+
{ current: '1.2.7', next: '1.2.7' },
51+
);
52+
53+
expect(versions).toEqual({
54+
'1.2.4': {
55+
releaseDate: '2023-12-28',
56+
slaStatus: 'eligible',
57+
supportStatus: 'eligible',
58+
},
59+
'1.2.5': {
60+
releaseDate: '2024-01-02',
61+
slaStatus: 'eligible',
62+
supportStatus: 'eligible',
63+
},
64+
'1.2.6': {
65+
releaseDate: '2024-01-02',
66+
slaStatus: 'eligible',
67+
supportStatus: 'eligible',
68+
},
69+
'1.2.7': {
70+
releaseDate: '2024-01-04',
71+
slaStatus: 'eligible',
72+
supportStatus: 'eligible',
73+
},
74+
});
75+
});
76+
4177
it('parses version of different minor', () => {
4278
const versions = generateLanguageVersionsHistory(
4379
[

Diff for: scripts/release/versionsHistory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export function generateLanguageVersionsHistory(
9191
}
9292

9393
// we skip any form of pre-releases because they are not part of the VersionsHistory
94-
if (isPreRelease(tagVersion)) {
94+
if (isPreRelease(tagVersion) || !semver.valid(tagVersion)) {
9595
continue;
9696
}
9797

0 commit comments

Comments
 (0)