-
Notifications
You must be signed in to change notification settings - Fork 332
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: change autocomplete from 'off' to 'nope' (#250)
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbbed04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why? My page had bug with it and for example https://www.lacoste.pl/ had the same bug right now. Nope is not correct value.
fbbed04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't a correct value on purpose so that it would not auto complete (be associated with an unknown key).
However it seems like this is really tricky behaviour and if this fix is causing more issues this probably should be reverted.
Can you see an autocomplete prompt change between the two versions?
fbbed04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With "nope" autocomplete is appearing over algolia-autocomplete like here: https://www.aptekagemini.pl/ (change is not on production yet). Same issue on Lacoste site. On chrome browser of course. Change "nope" on "off" fix the problem in my case.