feat(js): rename empty to noResults
#450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Feb 18, 2021
shortcuts
reviewed
Feb 18, 2021
|
|
||
| Function called to render an empty section when no hits are returned. It is useful for letting the user know that the query returned no results. | ||
| Function called to render a no results section when no hits are returned. It is useful for letting the user know that the query returned no results. |
There was a problem hiding this comment.
Suggested change
| Function called to render a no results section when no hits are returned. It is useful for letting the user know that the query returned no results. | |
| Function called to render a `no results` section when no hits are returned. It is useful for letting the user know that the query returned no results. |
I feel like this should be "escaped" as it's more a naming than a term, not sure if you see what I mean
There was a problem hiding this comment.
Yes I agree—the docs team is gonna rewrite all the API refs so I'll wait for them to judge what's best 🙂
shortcuts
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The name
emptywas rather confusing andnoResultsreflects better when this template is displayed.What
This renames all params that contain
emptytonoResults:templates.empty→templates.noResultsrenderEmpty→renderNoResults.aa-SourceEmpty→.aa-SourceNoResults