feat(autocomplete-core): add insights option to enable the Insights plugin
#1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienMotte
commented
Apr 13, 2023
| @@ -285,7 +286,7 @@ See: https://www.algolia.com/doc/ui-libraries/autocomplete/api-reference/autocom | |||
| }, | |||
| }); | |||
|
|
|||
| const input = container.querySelector<HTMLInputElement>('.aa-Input'); | |||
| const input = container.querySelector<HTMLInputElement>('.aa-Input')!; | |||
There was a problem hiding this comment.
Not related to the PR but I noticed a TS error since input can be null.
FabienMotte
requested review from
a team,
dhayab and
aymeric-giraudet
and removed request for
a team
Haroenv
approved these changes
Apr 17, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ffff04c:
|
…hts-plugin-setup # Conflicts: # packages/autocomplete-plugin-algolia-insights/src/types/EventParams.ts
Haroenv
pushed a commit
that referenced
this pull request
Apr 24, 2023
Haroenv
pushed a commit
that referenced
this pull request
Apr 24, 2023
Haroenv
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FX-2249
This PR adds an option
insightstoautocomplete-corepackage to enable the Insights plugin and load the Insights library if it has not been loaded yet.Results
When creating the Autocomplete instance, the
insightsoption can be used to enable the Insights plugin and load the Insights library if it has not been loaded yet. The option accepts abooleanor the Insights plugin parameters (that will be passed down to the default plugin).