Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): better accessibility for submit button label #1254

Merged
merged 1 commit into from
May 23, 2024

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented May 23, 2024

Summary

This PR adds an explicit aria-label on the label wrapping the submit button to pass accessibility tests.

Ultimately we should determine whether the label is useful, if not it should be removed in the next major as the button is sufficient for accessibility purposes.

Before

localhost_1234_ (1)

After

localhost_1234_

CR-6077

@dhayab dhayab requested review from a team, Haroenv and aymeric-giraudet and removed request for a team May 23, 2024 15:25
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd3be34:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@dhayab dhayab merged commit e0304ae into next May 23, 2024
9 checks passed
@dhayab dhayab deleted the fix/label-accessibility branch May 23, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants