Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): wrap item content when there's no link #522

Merged
merged 4 commits into from
Apr 12, 2021

Conversation

sarahdayan
Copy link
Member

We use CSS grids to display items in columns, meaning the grid algorithm always tries to render content into columns. For this reason, we need to make sure the HTML structure is always the same. This means you now always need to either wrap the item within aa-ItemWrapper OR aa-ItemLink.

This PR moves the grid display on aa-ItemWrapper and aa-ItemLink, and updates the documentation, demos and plugins to reflect the change.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b57d773:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-query-suggestion-with-categories Configuration
@algolia/autocomplete-example-query-suggestions-with-hits Configuration
@algolia/autocomplete-example-query-suggestions-with-inline-categories Configuration
@algolia/autocomplete-example-query-suggestions-with-recent-searches Configuration
@algolia/autocomplete-example-query-suggestions Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-recently-viewed-items Configuration
@algolia/autocomplete-example-starter Configuration

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge once we remove the unused Fragment imports.

examples/playground/app.tsx Outdated Show resolved Hide resolved
sarahdayan and others added 3 commits April 12, 2021 14:08
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
@sarahdayan sarahdayan merged commit c6afe42 into next Apr 12, 2021
@sarahdayan sarahdayan deleted the fix/theme-classic-wrapper branch April 12, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants