Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix collision between js/core and plugins #532

Merged
merged 6 commits into from
Apr 20, 2021

Conversation

shortcuts
Copy link
Member

Summary

There was a collision between the AutocompleteOptions/AutocompletePlugin types in js/core, which is now partially solved by making them looser.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2021

@shortcuts shortcuts marked this pull request as draft April 19, 2021 12:59
@shortcuts shortcuts marked this pull request as ready for review April 19, 2021 14:03
@shortcuts
Copy link
Member Author

shortcuts commented Apr 19, 2021

@francoischalifour I've removed the TState implementation from the PR and will handle it in a separate one.

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good to merge once the last piece of feedback is addressed.

@@ -6,7 +6,7 @@
"license": "MIT",
"main": "index.html",
"scripts": {
"build": "parcel build index.html",
"build": "parcel build index.html --dist-dir ./dist",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side, running the actual yarn build in parcel 2.0.0-beta.2 will output the build in the root folder.

Could you confirm this is also the case for you? If so, I'll update the other examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds it in the right folder for me.

What command did you run and from where?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the example folder (the root), with yarn build, yarn start works though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@shortcuts shortcuts merged commit ac79f67 into next Apr 20, 2021
@shortcuts shortcuts deleted the fix/exposedTypes branch April 20, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants