fix: support Chrome autofill when event.key is undefined
#1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powrrfulyang
requested review from
shortcuts and
francoischalifour
as code owners
👷 Deploy request for docsearch pending review.Visit the deploys page to approve it
|
shortcuts
reviewed
May 16, 2023
There was a problem hiding this comment.
is this for RSC or SSR purposes? looking at the types, it can't be undefined, but if this check solves it, it's not a huge deal to me
cc @francoischalifour wdyt?
|
chrome autocomplete in forms triggers 'keydown' but the event.key is undefined |
|
or it's a chrome BUG. |
|
scrnli_2023_5_16 20-27-03.webm |
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
|
English is not my native language; please forgive me if I offend you in any way. |
francoischalifour
changed the title
event.key is undefined
francoischalifour
approved these changes
May 16, 2023
|
@powerfulyang Nope, nothing to worry about 🙂 Thanks for your contribution! |
shortcuts
approved these changes
May 17, 2023
|
For anyone looking for the actual chrome issue https://issuetracker.google.com/issues/41425904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1887.