Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react 19 #2407

Open
Mister-Hope opened this issue Dec 15, 2024 · 2 comments
Open

Support react 19 #2407

Mister-Hope opened this issue Dec 15, 2024 · 2 comments

Comments

@Mister-Hope
Copy link

Describe the problem

React 19 has been published for a while, it would be great if docsearch and support react19, so users can get rid of issues caused by multiple versions of react.

@slorber
Copy link
Contributor

slorber commented Dec 26, 2024

Docusaurus website is using DocSearch with React 19 and it seems to work fine: https://docusaurus.io/

Maybe just allowing ^19 on peerDeps is enough?

@notaphplover
Copy link

notaphplover commented Jan 3, 2025

This is becoming a bottleneck for docusaurus users using the default theme. Since docusaurus 3.7, React 19 is supported, but depending on @docsearch/react as an outcome of depending on @docusaurus/theme-search-algolia generates a peer dependency conflict:

@docusaurus/theme-search-algolia 3.7.0
    └─┬ @docsearch/react 3.8.2
      ├── ✕ unmet peer react@">= 16.8.0 < 19.0.0": found 19.0.0
      ├── ✕ unmet peer @types/react@">= 16.8.0 < 19.0.0": found 19.0.2
      └── ✕ unmet peer react-dom@">= 16.8.0 < 19.0.0": found 19.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants