Accessibility issue

[oliviertassinari]

Do you want to request a feature or report a bug?

bug

What is the current behavior?

The following lighthouse test is failing:

You can reproduce it on Bootstrap or Material-UI with Chrome 68.

What is the expected behavior?

💯 % score

[s-pace]

Thank you for sharing. Do you need a fix asap or can it wait for the v3?

[oliviertassinari]

@s-pace as you see fit.

[Lausselloic]

Hello,

Looks like aria-label is not saved on destroy. On bootstrap there's an "aria-label" attribute on the search input, but when checking on docserach.js v2.6.2

// store the original values of the attrs that get modified
  // so modifications can be reverted on destroy
  $input.data(attrsKey, {
    'aria-autocomplete': $input.attr('aria-autocomplete'),
    'aria-expanded': $input.attr('aria-expanded'),
    'aria-owns': $input.attr('aria-owns'),
    autocomplete: $input.attr('autocomplete'),
    dir: $input.attr('dir'),
    role: $input.attr('role'),
    spellcheck: $input.attr('spellcheck'),
    style: $input.attr('style'),
    type: $input.attr('type')
  });

quick-fix will be to add aria-label to the saved attributes?

[endiliey]

It will be great to have this so that we can improve accessibility 😉 .

Edit: I sent a PR

[oliviertassinari]

I have patched the problem with: https://github.com/mui-org/material-ui/blob/e4ef5bf1adc6df6888a947919124302ed29d3343/docs/src/modules/components/AppSearch.js#L50-L67.

[endiliey]

Thanks @oliviertassinari. I've sent a PR for it but I guess I'll use your solution for now.

cc @s-pace

[endiliey]

We can close this out. I've resolved it after upgrading to 2.6.3

[s-pace]

Thanks again @endiliey, version released 🚀

[oliviertassinari]

Do we have to wait a week to see the CDN cache expire?

[s-pace]

Should be updated :)

[Lausselloic]

thanks for the fix. Works well