Skip to content

Commit 64d6011

Browse files
vvoredox
vvo
authored andcommitted
fix(React): require React in order for JSX to work in widgets
Problem: we now use ReactDom.render in widgets/*. JSX is compiled to React.createElement. React is not defined since not in the current scope. Solutions: - require React and move on (and ignore the eslint check) - use React.createElement by hand and do not use JSX in widgets I did the first solution. Easier :)
1 parent d880ea2 commit 64d6011

11 files changed

+15
-1
lines changed

.eslintrc

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
{
2-
"extends": "algolia"
2+
"extends": "algolia",
3+
"rules": {
4+
"no-unused-vars": [2, {"vars": "local", "args": "after-used", "varsIgnorePattern": "^React$"}],
5+
}
36
}

index.js

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
var React = require('react');
2+
13
require('./shams/Object.freeze.js');
24

35
var toFactory = require('to-factory');

widgets/hierarchicalMenu.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var utils = require('../lib/utils.js');

widgets/hits.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var utils = require('../lib/utils.js');

widgets/index-selector.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var findIndex = require('lodash/array/findIndex');

widgets/menu.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var utils = require('../lib/utils.js');

widgets/pagination.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23
var defaults = require('lodash/object/defaults');
34

widgets/range-slider.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var utils = require('../lib/utils.js');

widgets/refinement-list.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var utils = require('../lib/utils.js');

widgets/stats/index.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var React = require('react');
12
var ReactDOM = require('react-dom');
23

34
var utils = require('../../lib/utils.js');

widgets/toggle.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
var find = require('lodash/collection/find');
2+
var React = require('react');
23
var ReactDOM = require('react-dom');
34

45
var utils = require('../lib/utils.js');

0 commit comments

Comments
 (0)