Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): depend on sync version of React InstantSearch Hooks #5600

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Apr 18, 2023

Summary

For some reason (possibly the PR introducing this package) was merged with a version that wasn't the latest React InstantSearch Hooks as dependency, and thus doesn't get updated by shipjs during releases.

In a different PR, we should change those dependencies to caret so they are more robust.

Result

fixes #5568

For some reason (possibly the PR introducing this package) was merged with a version that wasn't the latest React InstantSearch Hooks as dependency, and thus doesn't get updated by shipjs during releases.

fixes #5568

In a different PR, we should change those dependencies to caret so they are more robust.
@Haroenv Haroenv requested review from aymeric-giraudet, a team and dhayab and removed request for a team April 18, 2023 07:56
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef9966b:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-hooks-default-theme Configuration
example-vue-instantsearch-default-theme Configuration

@Haroenv Haroenv merged commit 82cfbd8 into master Apr 18, 2023
@Haroenv Haroenv deleted the fix/router-dependency-version branch April 18, 2023 12:12
@Haroenv Haroenv mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-hooks next example with npm package manager is not working
2 participants