-
Notifications
You must be signed in to change notification settings - Fork 530
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(RefinementList): remove root css class on sublists (#4117)
**Summary** The RefinementList is the component used for rendering of the HierarchicalMenu widget. When a given item of the HierarchicalMenu has children, the RefinementList is recursively called, with the same cssClasses prop. As a result, the `cssClasses.root` is appearing on every list of children. This change is proposed because: 1. This is not the specified behaviour. 2. This is not the behaviour observed on InstantSearch V2. In V2, the `cssClasses.root` belonged to the [headerFooter HOC](https://github.com/algolia/instantsearch.js/blob/v2/src/decorators/headerFooter.js#L22). The problem emerged in InstantSearch V3 as the `cssClasses.root` property was moved inside the RefinementList widget.
- Loading branch information
1 parent
6451dce
commit 9581a41
Showing
2 changed files
with
34 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters