Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence React dev warnings #330

Closed
Jerska opened this issue Oct 22, 2015 · 5 comments
Closed

Silence React dev warnings #330

Jerska opened this issue Oct 22, 2015 · 5 comments
Labels
Type: Bug
Milestone
1.0.0

Comments

@Jerska
Copy link
Member

Jerska commented Oct 22, 2015

After started using v0.5.0, I'm getting a console log with "Download the React DevTools for a better development experience: https://fb.me/react-devtools", which is a bit annoying.

It seems like browserifying with NODE_ENV=production makes these warning messages disappear (See facebook/react#3877 ).

Could we do that for our releases?
@vvo vvo added this to the 1.0.0 milestone Oct 22, 2015
@vvo
Copy link
Contributor

vvo commented Oct 22, 2015

Yes we need so

@Jerska
Copy link
Member Author

Jerska commented Oct 22, 2015

It seems like we might also need to define a webpack plugin : facebook/react#3877 (comment) .

@Jerska
Copy link
Member Author

Jerska commented Oct 22, 2015

👍 @vvo

@vvo vvo closed this as completed in 20aedf5 Oct 22, 2015
@bobylito
Copy link
Contributor

We could also solve the dev issues...

@vvo
Copy link
Contributor

vvo commented Oct 22, 2015

@bobylito The dev issues we have we will still see them, always in dev mode and tests and we have #309 to track them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@vvo @bobylito @Jerska