fix(vue-instantsearch): compute initial state from helper instead of results #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
commented
Jan 2, 2023
| @@ -13,6 +13,7 @@ | |||
| "dependencies": { | |||
| "algoliasearch": "4.14.3", | |||
| "cross-env": "^5.2.0", | |||
| "css-loader": "^4.3.0", | |||
There was a problem hiding this comment.
Without this line, the example doesn't run (probably due to it being in a monorepo now). I set the version to one that is already in yarn.lock.
dhayab
requested review from
a team,
sarahdayan,
aymeric-giraudet and
Haroenv
and removed request for
a team
Haroenv
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
I believe this option was discussed in algolia/vue-instantsearch#764 too, but it's correct like this. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, for SSR, we compute
initialResultson the server using the helper results. This is used for initial rendering as well as for hydration. Because nested indices inherit from their parent, they are set with a merged state which prevent correct inheritance behavior later on, when interacting with InstantSearch client-side.This PR instead relies on the index's helper "request" state, which isn't merged and allows expected behavior.
CR-2516
fixes #5383