feat(rendering): revert search state on error #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 72f2b16:
|
Haroenv
commented
Jan 20, 2023
Comment on lines
+589
to
+598
| // we can't attach a listener to the error event of search, as the error | ||
| // then would no longer be thrown for global handlers. | ||
| if ( | ||
| instantSearchInstance.status === 'error' && | ||
| !instantSearchInstance.mainHelper!.hasPendingRequests() | ||
| ) { | ||
| helper!.setState(lastValidSearchParameters!); | ||
| } | ||
|
|
There was a problem hiding this comment.
I wonder if this can be put somewhere else? I thought in InstantSearch error handler, but that doesn't know local state etc, so would require a dedicated method on index widget.
I guess this could be problematic if render is called another time after error, with error again, it will again reset. (which is a little superfluous, but still correct)
Haroenv
changed the title
Haroenv
force-pushed
the
feat/revert-on-error
branch
from
2e30ce2 to
dd65aff
Compare
Haroenv
requested review from
a team,
FabienMotte and
sarahdayan
and removed request for
a team
Haroenv
force-pushed
the
feat/revert-on-error
branch
from
8ea34e7 to
c5c21e5
Compare
Haroenv
commented
Jan 23, 2023
Haroenv
added a commit
that referenced
this pull request
Jan 23, 2023
**Summary** This change enables optimistic rendering, as discussed in [RFC 82](algolia/instantsearch-rfcs#82) and also #4403. This doesn't (yet) implement reverting the state on error, as it is done in #5438. **Result** - when the search/loading starts, a **render** happens as well - when we render, we use the **current** SearchParameters for _state in SearchResults - fix all edge cases that didn't correctly detect idle state before persisting state - introduce common unit/integration tests for optimistic ui in RefinementList, Pagination, Menu, HierarchicalMenu Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Sarah Dayan <sarahdayan@users.noreply.github.com>
Haroenv
force-pushed
the
feat/revert-on-error
branch
from
5662e8c to
ac9d640
Compare
Haroenv
force-pushed
the
feat/revert-on-error
branch
from
cc02675 to
72f2b16
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
going a step further than #5429, we want to also when there's an error revert to the last known good state.
Result
This goes back to the previous (non-optimistic) behaviour when an error happens, with a caveat that the state will be fully consistent. That means UiState and the URL also update back to the previous state