fix(breadcrumb): guard against undefined facets #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a breadcrumb widget gets "its" hierarchical menu added dynamically, there will be a render where getFacetValues returns `undefined`. I checked, and all other cases of `getFacetValues` guard already for its result possibly being undefined. Also added the common test for optimistic UI for breadcrumb, as it's a related fix.
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f76bbd9:
|
dhayab
approved these changes
Feb 20, 2023
|
@Haroenv should this guard be also applied to the hierarchical menu as well? |
Hierarchical menu, menu, refinement list etc. already have this guard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a breadcrumb widget gets "its" hierarchical menu added dynamically, there will be a render where getFacetValues returns
undefined.I checked, and all other cases of
getFacetValuesguard already for its result possibly being undefined.Also added the common test for optimistic UI for breadcrumb, as it's a related fix.
Result
No error when hierarchical menu for a breadcrumb gets added dynamically