feat(insights): prevent potential errors #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de9bf32:
|
dhayab
reviewed
Feb 21, 2023
dhayab
approved these changes
Feb 21, 2023
aymeric-giraudet
approved these changes
Feb 21, 2023
Base automatically changed from
feat/automatic-insights-client
to
feat/automatic-insights
February 21, 2023 13:23
To better prepare for the insights middleware being automatically added, we are making the following changes: - useCookie by default true so userToken does not need to be provided - still call `insightsClient` if no userToken is found (userToken can be applied using useCookie, thus not known) - error on unknown algolia credentials converted to warning
Haroenv
force-pushed
the
feat/automatic-insights-allow-auto
branch
from
4685922 to
de9bf32
Compare
FabienMotte
approved these changes
Feb 21, 2023
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
To better prepare for the insights middleware being automatically added, we are making the following changes: - useCookie by default true so userToken does not need to be provided - still call `insightsClient` if no userToken is found (userToken can be applied using useCookie, thus not known) - error on unknown algolia credentials converted to warning
Haroenv
added a commit
that referenced
this pull request
Mar 8, 2023
To better prepare for the insights middleware being automatically added, we are making the following changes: - useCookie by default true so userToken does not need to be provided - still call `insightsClient` if no userToken is found (userToken can be applied using useCookie, thus not known) - error on unknown algolia credentials converted to warning
Haroenv
added a commit
that referenced
this pull request
Apr 18, 2023
To better prepare for the insights middleware being automatically added, we are making the following changes: - useCookie by default true so userToken does not need to be provided - still call `insightsClient` if no userToken is found (userToken can be applied using useCookie, thus not known) - error on unknown algolia credentials converted to warning
Haroenv
added a commit
that referenced
this pull request
Apr 24, 2023
To better prepare for the insights middleware being automatically added, we are making the following changes: - useCookie by default true so userToken does not need to be provided - still call `insightsClient` if no userToken is found (userToken can be applied using useCookie, thus not known) - error on unknown algolia credentials converted to warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better prepare for the insights middleware being automatically added, we are making the following changes:
insightsClientif no userToken is found (userToken can be applied using useCookie, thus not known)prep for FX-2248