feat(createInsightsMiddleware): always pass Algolia credentials locally #5554
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b73dfd:
|
sarahdayan
force-pushed
the
feat/local-insights-credentials
branch
from
1299efc to
71f997d
Compare
| instantSearchInstance.sendEventToInsights = (event: InsightsEvent) => { | ||
| if (onEvent) { | ||
| onEvent(event, _insightsClient as TInsightsClient); |
There was a problem hiding this comment.
I believe passing _insightsClient here was a bug, as this wouldn't point to the right function in an auto-pulled scenario.
There was a problem hiding this comment.
ah yes, with auto-pulling that is wrong, but it used to be the user-provided one on purpose in case someone passes null, the insightsClient would be null and not noop, but that's not very different
There was a problem hiding this comment.
Do you think it should stay nullable (e.g., when opting-out of auto-pull)?
sarahdayan
force-pushed
the
feat/local-insights-credentials
branch
from
71f997d to
102d61f
Compare
sarahdayan
force-pushed
the
feat/local-insights-credentials
branch
from
102d61f to
0b73dfd
Compare
| // @ts-ignore | ||
| const insightsClientWithLocalCredentials = (method, payload) => { |
There was a problem hiding this comment.
| // @ts-ignore | |
| const insightsClientWithLocalCredentials = (method, payload) => { | |
| const insightsClientWithLocalCredentials: InsightsClient = (method, payload) => { |
does that work without angering TS?
There was a problem hiding this comment.
Not yet, we need to release the new version of the Insights client so that the types are up to date.
I can do it in a different PR if we don't release it before we're ready to merge this one.
This attaches the Algolia credentials to each event we send, via
headers.The goal is to ensure events are always sent to the right app even when the Insights client is shared—for example, when using InstantSearch together with Autocomplete.
FX-2278