-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(createServerRootMixin): forward i18n on option #5673
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 363fa2f:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you put this after line#33 in that same file? there are other properties copied in a similar way.
A test would also be very useful!
Thanks for your PR, this will be useful :) |
@Haroenv I have added for i18n for both vue3 and vue2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks correct! I'll just make sure CI runs
Issue during SSR, i18n is not defined inside the cloned component instance
This fix solve the issue by adding $i18n in the options of the cloned component.