fix(accessibility): CR-4249 instantearch accessibility fixes #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 742b35a:
|
…CR-4249/accessibility-fixes
…lia/instantsearch into CR-4249/accessibility-fixes
Haroenv
reviewed
Oct 5, 2023
packages/instantsearch.js/src/components/Pagination/Pagination.tsx
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/components/SearchBox/SearchBox.tsx
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/components/SearchBox/SearchBox.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch/src/ui/__tests__/Pagination.test.tsx
Outdated
Show resolved
Hide resolved
dhayab
reviewed
Oct 10, 2023
packages/instantsearch.js/src/components/Pagination/Pagination.tsx
Outdated
Show resolved
Hide resolved
|
@paynerichards it seems there are unresolved snapshot mismatchs, probably in /tests/common/widgets/pagination/option.ts. Is it solved when rerunning a snapshot update command with Jest? |
|
I believe the tests are still failing because Vue InstantSearch pagination might not be updated? |
|
Yes, the test and behaviour is common for all flavours, so the change should be done everywhere, thanks! If you can also do it in /specs, that would be ideal. Sorry for missing that in earlier reviews |
Haroenv
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses accessibility concerns brought up in CR-429 by adding ARIA labels to slider handles and sortBy menu, and expanding on pagination labels
Also: CR-1201 adding aria-label to SearchBox
Result
Targeted areas have accessible labels