test: hydrateSearchClient to make sure it caches results
#5913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ca599a:
|
Haroenv
reviewed
Oct 30, 2023
packages/instantsearch.js/src/lib/utils/__tests__/hydrateSearchClient-test.ts
Show resolved
Hide resolved
aymeric-giraudet
force-pushed
the
test/ris-hydrate-search-client
branch
from
ae2781f to
e8b21ec
Compare
Haroenv
approved these changes
Oct 30, 2023
aymeric-giraudet
force-pushed
the
test/ris-hydrate-search-client
branch
2 times, most recently
from
df7dc4b to
2b37730
Compare
aymeric-giraudet
force-pushed
the
test/ris-hydrate-search-client
branch
from
2b37730 to
7ca599a
Compare
aymeric-giraudet
added a commit
that referenced
this pull request
Oct 31, 2023
* feat(react-instantsearch): hydrate search client * move function call in instantsearch.js * test: `hydrateSearchClient` to make sure it caches results (#5913) * test: add tests for `hydrateSearchClient` function * add test in InstantSearchSSRProvider * update bundlesize --------- Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FX-2647
I started making e2e tests with wdio-intercept-service but due to limitations with selenium, there's no way to intercept requests made when the page loads reliably, only requests resulting from user actions can be tested :/
We would have to use Cypress or Puppeteer to test it then.
So this just tests the implementation itself, which is still better than nothing 😅
Also changed
Object.valuestoObject.keysfor it to build properly.