Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats): add common test suite #5931

Merged
merged 6 commits into from
Nov 16, 2023
Merged

feat(stats): add common test suite #5931

merged 6 commits into from
Nov 16, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Nov 15, 2023

This migrates per-flavour tests for the stats widget to the common test suite, and reduce flavour-specific tests.

This also aligns the default copy for React and Vue to the one implemented in InstantSearch.js, bringing pluralization in the stats displayed.

FX-2035

Copy link

codesandbox-ci bot commented Nov 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7d4638:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

@dhayab dhayab requested review from a team, sarahdayan and Haroenv and removed request for a team November 15, 2023 14:01
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/vue-instantsearch/src/components/Stats.vue Outdated Show resolved Hide resolved
tests/common/widgets/stats/options.ts Outdated Show resolved Hide resolved
tests/common/widgets/stats/options.ts Outdated Show resolved Hide resolved
@dhayab dhayab merged commit 16e9b34 into master Nov 16, 2023
12 checks passed
@dhayab dhayab deleted the tests/stats branch November 16, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants